Implement DoubleEndedIterator for ProcessResults #910
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #910 +/- ##
==========================================
+ Coverage 94.38% 94.43% +0.04%
==========================================
Files 48 48
Lines 6665 6829 +164
==========================================
+ Hits 6291 6449 +158
- Misses 374 380 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
This looks good to me, and I appreciate the update on specialization tests.
However, this leads to a change in meaning. That way, the first error encountered is not necessarily the first in the iterator order. I know that's the all point but I'm unsure about such change.
We can it.rev().process_results(..) if we only need it in reverse so this change only matters when we need both iteration sides. Do you have an example?
EDIT: I see you are the original author of process_results, thanks!
No description provided.